Repository navigation
refactor: Unify CLI request and error handling - #33
Open
sidneyswift wants to merge 1 commit into
Open
sidneyswift wants to merge 1 commit into
sidneyswift wants to merge 1 commit into
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars.
 |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Use one private request transport beneath existing GET/POST interfaces; preserve query, headers, bodies and HTTP/application error behavior.
Verification
94 tests in 14 files and production build pass. Independent reviewer repeated 17 client tests and found no actionable issues.
Scope and review
Part of the user-requested Recoup monorepo untangle-codebase workflow. Audit and decision log preceded implementation. Changes stay in this owning repository; no production deployment or main-branch merge requested. No broad comment/test-pruning sweep. Existing local work and retired checkouts preserved.
Each repository PR is independently reviewable; the Mono report will collect the coordinated audit, retained cases and check limitations.
Summary by cubic
Unifies
getandpostbehind a single privaterequesthelper so query building, headers, body handling, and error policy live in one place. No behavior change for callers:GETandPOSTresponses keep the existing error precedence (data.error, thendata.message, thenRequest failed: <status>), and malformed JSON now propagates without retrying.Written for commit 6b5f458. Summary will update on new commits.